Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setting to change TTL on AccessVerifier #1941

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add setting to change TTL on AccessVerifier #1941

wants to merge 1 commit into from
+3 −5

Conversation

bfcoder
Copy link
Contributor

@bfcoder bfcoder commented Sep 21, 2021 •
edited
Loading

5 minutes sometimes just isn't enough. This makes it so it is configurable and not hard coded.

Test Plan:

  • Add a video to a course files
  • Insert a video tag into the html of a page. ie:
<p><video style="border: 2px solid black;" width="450" height="225" controls="controls">
<source src="/courses/<course_id>/files/<file_id>/download" /></video></p>
  • Inspect the network traffic while watching the video.
  • Obtain the jwt used to download the video.
  • Inspect that jwt and the exp should be the minutes out of what ever is set in the Setting, default 5 minutes.

@bfcoder bfcoder force-pushed the bf/access-verifier-ttl-setting branch from c3ffc84 to 5915d1d Compare September 28, 2021 20:25
@bfcoder
Copy link
Contributor Author

bfcoder commented Nov 15, 2021

@maths22 Any chance you can take a look at this soon? Thanks!

@bfcoder
Add setting to change ttl on AccessVerifier
3426305 
5 minutes sometimes just isn't enough. This makes it so it is configurable and not hard coded.

Test Plan:

* Add a video to a course
* insert a video tag into the html of a page. ie:
```
<p><video style="border: 2px solid black;" width="450" height="225" controls="controls">
<source src="/courses/<course_id>/files/<file_id>/download" /></video></p>
```
* Inspect the network traffic while watching the video.
* Obtain the jwt used to download the video.
* Inspect that jwt and the exp should be the minutes out of what ever is set in the Setting, default 5 minutes.
@bfcoder bfcoder force-pushed the bf/access-verifier-ttl-setting branch from 5915d1d to 3426305 Compare March 21, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maths22 maths22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bfcoder @maths22